Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update types to match js-sdk --strict mode #9528

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 1, 2022

Requires matrix-org/matrix-events-sdk#16


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 1, 2022
@t3chguy t3chguy requested a review from a team as a code owner November 1, 2022 12:07
weeman1337
weeman1337 previously approved these changes Nov 2, 2022
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@weeman1337 weeman1337 self-requested a review November 2, 2022 13:29
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about room id.

Sorry for the 👍 before; I was too fast 🐇

@weeman1337 weeman1337 dismissed their stale review November 2, 2022 13:31

New review

Co-authored-by: Michael Weimann <michaelw@matrix.org>
@t3chguy t3chguy merged commit 5f540eb into develop Nov 3, 2022
@t3chguy t3chguy deleted the t3chguy/tsc-strict4 branch November 3, 2022 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants