Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix the picture-in-picture component being off screen #9246

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

robintown
Copy link
Member

@robintown robintown commented Sep 6, 2022

No regression test provided because I'm currently lacking the time, and am not immediately sure how to write a Cypress test for this area.

Closes element-hq/element-web#23198
Regressed by 1aa4e81

Notes: none
element-web notes: none


This change has no change notes, so will not be included in the changelog.

@robintown robintown added X-Release-Blocker This affects the current release cycle and must be solved for a release to happen T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Sep 6, 2022
@robintown robintown requested a review from a team as a code owner September 6, 2022 03:45
@robintown robintown enabled auto-merge (squash) September 6, 2022 03:45
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please make an issue to add tests?

@robintown robintown merged commit 4524291 into matrix-org:develop Sep 6, 2022
@robintown
Copy link
Member Author

Noted on element-hq/element-web#21524

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picture-in-picture elements are off the page
2 participants