Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Refactor login flow types into matrix-js-sdk #9232

Merged
merged 7 commits into from
Sep 22, 2022
Merged

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 1, 2022

The corresponding PR for matrix-js-sdk is matrix-org/matrix-js-sdk#2669 which must be merged at the same time (was originally part of matrix-org/matrix-js-sdk#2633)

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@hughns hughns added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 1, 2022
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears as though a commit is missing - this does not compile.

@hughns
Copy link
Member Author

hughns commented Sep 11, 2022

@turt2live unless you are looking at something different, is the issue that it depends on the js-sdk branch given by matrix-org/matrix-js-sdk#2633?

@hughns
Copy link
Member Author

hughns commented Sep 11, 2022

@turt2live the required changes are now on js-sdk develop branch but don't seem to be pulled in for the test on this PR. What have I done wrong? 🤦‍♂️

@turt2live turt2live self-requested a review September 11, 2022 22:58
@turt2live
Copy link
Member

it's probably the lockfile being a huge pain, but let's see if another merge does it.

Initial review was based on the diff being a large shade of red, fwiw - didn't see the js-sdk PR at all and it should have considered it as part of the build.

@turt2live
Copy link
Member

oh, the react-sdk PR got reverted.

@hughns what's the status of this?

@hughns
Copy link
Member Author

hughns commented Sep 14, 2022

@turt2live the status is that there is a new smaller PR matrix-org/matrix-js-sdk#2669 which does the remaining change (which is what broke react-sdk earlier in the week).

src/Login.ts Outdated Show resolved Hide resolved
Co-authored-by: Travis Ralston <travisr@matrix.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants