-
-
Notifications
You must be signed in to change notification settings - Fork 832
Refactor login flow types into matrix-js-sdk #9232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it appears as though a commit is missing - this does not compile.
@turt2live unless you are looking at something different, is the issue that it depends on the js-sdk branch given by matrix-org/matrix-js-sdk#2633? |
@turt2live the required changes are now on js-sdk develop branch but don't seem to be pulled in for the test on this PR. What have I done wrong? 🤦♂️ |
it's probably the lockfile being a huge pain, but let's see if another merge does it. Initial review was based on the diff being a large shade of red, fwiw - didn't see the js-sdk PR at all and it should have considered it as part of the build. |
oh, the react-sdk PR got reverted. @hughns what's the status of this? |
@turt2live the status is that there is a new smaller PR matrix-org/matrix-js-sdk#2669 which does the remaining change (which is what broke react-sdk earlier in the week). |
Co-authored-by: Travis Ralston <travisr@matrix.org>
The corresponding PR for matrix-js-sdk is matrix-org/matrix-js-sdk#2669 which must be merged at the same time (was originally part of
matrix-org/matrix-js-sdk#2633)Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.