Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use "frequently used emojis" for autocompletion in composer #8998

Merged
merged 8 commits into from
Jul 21, 2022
Merged

Use "frequently used emojis" for autocompletion in composer #8998

merged 8 commits into from
Jul 21, 2022

Conversation

grimhilt
Copy link
Contributor

@grimhilt grimhilt commented Jul 6, 2022 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#18978

Place "frequently used emojis" on top position in the composer autocomplete panel.

Signed-off-by: grimhilt@users.noreply.github.com

Here's what your changelog entry will look like:

✨ Features

@grimhilt grimhilt requested a review from a team as a code owner July 6, 2022 15:13
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jul 6, 2022
SimonBrandner
SimonBrandner reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

This is going to need a design review

src/autocomplete/EmojiProvider.tsx Outdated Show resolved Hide resolved
src/autocomplete/EmojiProvider.tsx Outdated Show resolved Hide resolved
src/autocomplete/EmojiProvider.tsx Outdated Show resolved Hide resolved
@SimonBrandner SimonBrandner requested a review from a team July 6, 2022 15:46
SimonBrandner
SimonBrandner suggested changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane codewise though I think it would be good to have tests for this, if possible

@SimonBrandner SimonBrandner added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 8, 2022
SimonBrandner
SimonBrandner approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM codewise!

@amshakal amshakal requested review from niquewoodhouse and removed request for a team July 13, 2022 15:45
@niquewoodhouse niquewoodhouse self-assigned this Jul 18, 2022
niquewoodhouse
niquewoodhouse reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@niquewoodhouse niquewoodhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Place "frequently used emojis" on top position in the composer autocomplete panel.

Could we have an explicit before and after screenshot/video of what the proposed change is for users please? In testing I've struggled to know exactly what's changed. I've tested with a few emojis but don't feel confident I can tell what's changed.

Question: What defines what's frequently used and how is that logic maintained?

Current:
image

Proposal:
image

image

@grimhilt
Copy link
Contributor Author

grimhilt commented Jul 20, 2022 •
edited
Loading

Frequently used emojis are defined by the number of time there are been used, I didn't implement that, I used the same list as in the emoji picker under the category "Frequently used".

Current :
image

Proposal :
image

The emojis present in the category "Frequently used" of the emoji picker (so the frequently used emojis) will be shown first for autocompletion. In this example by default lollipop is not the first recommendation by default but as this user seems to use it frequently it will be place on top of lock.

@niquewoodhouse niquewoodhouse self-requested a review July 21, 2022 12:09
@SimonBrandner SimonBrandner merged commit 35ba389 into matrix-org:develop Jul 21, 2022
su-ex added a commit to SchildiChat/element-desktop that referenced this pull request Aug 22, 2022
@su-ex
Merge tag 'v1.11.2' into sc
2996b7b 
* Live location share -  focus on user location on list item click ([\#9051](matrix-org/matrix-react-sdk#9051)). Contributed by @kerryarchibald.
* Live location sharing - don't trigger unread counts for beacon location events ([\#9071](matrix-org/matrix-react-sdk#9071)). Contributed by @kerryarchibald.
* Support for sending voice messages as replies and in threads ([\#9097](matrix-org/matrix-react-sdk#9097)). Fixes element-hq/element-web#22031.
* Add `Reply in thread` button to the right-click message context-menu ([\#9004](matrix-org/matrix-react-sdk#9004)). Fixes element-hq/element-web#22745.
* Starred_Messages_Feature_Contd_II/Outreachy ([\#9086](matrix-org/matrix-react-sdk#9086)).
* Use "frequently used emojis" for autocompletion in composer ([\#8998](matrix-org/matrix-react-sdk#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt.
* Improve clickability of view source event toggle button  ([\#9068](matrix-org/matrix-react-sdk#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul.
* Improve clickability of "collapse" link button on bubble layout ([\#9037](matrix-org/matrix-react-sdk#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul.
* Starred_Messages_Feature/Outreachy ([\#8842](matrix-org/matrix-react-sdk#8842)).
* Implement Use Case Selection screen ([\#8984](matrix-org/matrix-react-sdk#8984)). Contributed by @justjanne.
* Live location share - handle insufficient permissions in location sharing ([\#9047](matrix-org/matrix-react-sdk#9047)). Contributed by @kerryarchibald.
* Improve _FilePanel.scss ([\#9031](matrix-org/matrix-react-sdk#9031)). Contributed by @luixxiul.
* Improve spotlight accessibility by adding context menus ([\#8907](matrix-org/matrix-react-sdk#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne.
* Replace mask-images with svg components in MessageActionBar ([\#9088](matrix-org/matrix-react-sdk#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips ([\#9087](matrix-org/matrix-react-sdk#9087)). Fixes element-hq/element-web#22874.
* Show a back button when viewing a space member ([\#9095](matrix-org/matrix-react-sdk#9095)). Fixes element-hq/element-web#22898.
* Align the right edge of info tile lines with normal ones on IRC layout ([\#9058](matrix-org/matrix-react-sdk#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul.
* Prevent email verification from overriding existing sessions ([\#9075](matrix-org/matrix-react-sdk#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne.
* Fix wrong buttons being used when exploring public rooms ([\#9062](matrix-org/matrix-react-sdk#9062)). Fixes element-hq/element-web#22862.
* Re-add padding to generic event list summary on IRC layout ([\#9063](matrix-org/matrix-react-sdk#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul.
* Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\#9055](matrix-org/matrix-react-sdk#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request Aug 22, 2022
@su-ex
Merge tag 'v3.51.0' into sc
8cb2754 
* Live location share -  focus on user location on list item click ([\matrix-org#9051](matrix-org#9051)). Contributed by @kerryarchibald.
* Live location sharing - don't trigger unread counts for beacon location events ([\matrix-org#9071](matrix-org#9071)). Contributed by @kerryarchibald.
* Support for sending voice messages as replies and in threads ([\matrix-org#9097](matrix-org#9097)). Fixes element-hq/element-web#22031.
* Add `Reply in thread` button to the right-click message context-menu ([\matrix-org#9004](matrix-org#9004)). Fixes element-hq/element-web#22745.
* Starred_Messages_Feature_Contd_II/Outreachy ([\matrix-org#9086](matrix-org#9086)).
*  Use "frequently used emojis" for autocompletion in composer ([\matrix-org#8998](matrix-org#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt.
* Improve clickability of view source event toggle button  ([\matrix-org#9068](matrix-org#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul.
* Improve clickability of "collapse" link button on bubble layout ([\matrix-org#9037](matrix-org#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul.
* Starred_Messages_Feature/Outreachy ([\matrix-org#8842](matrix-org#8842)).
* Implement Use Case Selection screen ([\matrix-org#8984](matrix-org#8984)). Contributed by @justjanne.
* Live location share - handle insufficient permissions in location sharing ([\matrix-org#9047](matrix-org#9047)). Contributed by @kerryarchibald.
* Improve _FilePanel.scss ([\matrix-org#9031](matrix-org#9031)). Contributed by @luixxiul.
* Improve spotlight accessibility by adding context menus ([\matrix-org#8907](matrix-org#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne.
* Replace mask-images with svg components in MessageActionBar ([\matrix-org#9088](matrix-org#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips ([\matrix-org#9087](matrix-org#9087)). Fixes element-hq/element-web#22874.
* Show a back button when viewing a space member ([\matrix-org#9095](matrix-org#9095)). Fixes element-hq/element-web#22898.
* Align the right edge of info tile lines with normal ones on IRC layout ([\matrix-org#9058](matrix-org#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul.
* Prevent email verification from overriding existing sessions ([\matrix-org#9075](matrix-org#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne.
* Fix wrong buttons being used when exploring public rooms ([\matrix-org#9062](matrix-org#9062)). Fixes element-hq/element-web#22862.
* Re-add padding to generic event list summary on IRC layout ([\matrix-org#9063](matrix-org#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul.
* Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\matrix-org#9055](matrix-org#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

@niquewoodhouse niquewoodhouse niquewoodhouse approved these changes

Assignees

@niquewoodhouse niquewoodhouse

Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emoji selection/picker should favor emojis which are used more often
3 participants
@grimhilt @niquewoodhouse @SimonBrandner