Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Advanced audio processing settings #8759

Merged
merged 13 commits into from
Nov 9, 2022

Commits on Oct 22, 2022

  1. settings: reorganize VoiseUserSettingsTab

    This is a preparation step for adding new advanced voice processing options
    to the settings tab.
    
    3 sections have been added: Voice, Video, and Advanced
    
    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    MrAnno committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    6def45b View commit details
    Browse the repository at this point in the history
  2. Add advanced audio settings

    autoGainControl, echoCancellation, and noiseSuppression are audio
    processing options that are usually enabled by default on WebRTC input
    tracks.
    
    This commit adds the possibility to enable/disable them, as they can be
    undesirable in some cases (audiophile use cases). For example, one might
    want to stream electronic dance music, which is basically noise, so it
    should not be suppressed in that specific case.
    
    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    MrAnno committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    538ad86 View commit details
    Browse the repository at this point in the history
  3. settings: use composition for VoiceUserSettingsTab's state

    IState does not seem to be in an "IS-A" relation with
    MediaDeviceKindEnum-based records (Liskov substitution principle), so
    applying the "composition over inheritance" concept might be a good idea.
    
    This can be refactored further by adding separate types for I/O device
    options and for audio settings and then using them in IState via
    composition.
    
    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    MrAnno committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    080b91d View commit details
    Browse the repository at this point in the history
  4. settings: add secondary line descriptions for p2p calls and fallbackICE

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    MrAnno committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    aee4449 View commit details
    Browse the repository at this point in the history
  5. settings: UX refactor of advanced audio processing options

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    MrAnno committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    328c2f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Configuration menu
    Copy the full SHA
    c453176 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Configuration menu
    Copy the full SHA
    bc4f2b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Configuration menu
    Copy the full SHA
    d2bb279 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6fb733 View commit details
    Browse the repository at this point in the history
  3. test: add test for MediaDeviceHandler

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    MrAnno committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    4187efd View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. settings: allow null values

    There are multiple examples of options with null defaults.
    
    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    MrAnno committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    bf024e2 View commit details
    Browse the repository at this point in the history
  2. test: add test for VoiceUserSettingsTab

    Signed-off-by: László Várady <laszlo.varady@protonmail.com>
    MrAnno committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    69b1eec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    500c42c View commit details
    Browse the repository at this point in the history