This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 832
Advanced audio processing settings #8759
Merged
SimonBrandner
merged 13 commits into
matrix-org:develop
from
MrAnno:audio-processing-settings
Nov 9, 2022
Merged
Advanced audio processing settings #8759
SimonBrandner
merged 13 commits into
matrix-org:develop
from
MrAnno:audio-processing-settings
Nov 9, 2022
Commits on Oct 22, 2022
-
settings: reorganize VoiseUserSettingsTab
This is a preparation step for adding new advanced voice processing options to the settings tab. 3 sections have been added: Voice, Video, and Advanced Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6def45b - Browse repository at this point
Copy the full SHA 6def45bView commit details -
autoGainControl, echoCancellation, and noiseSuppression are audio processing options that are usually enabled by default on WebRTC input tracks. This commit adds the possibility to enable/disable them, as they can be undesirable in some cases (audiophile use cases). For example, one might want to stream electronic dance music, which is basically noise, so it should not be suppressed in that specific case. Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 538ad86 - Browse repository at this point
Copy the full SHA 538ad86View commit details -
settings: use composition for VoiceUserSettingsTab's state
IState does not seem to be in an "IS-A" relation with MediaDeviceKindEnum-based records (Liskov substitution principle), so applying the "composition over inheritance" concept might be a good idea. This can be refactored further by adding separate types for I/O device options and for audio settings and then using them in IState via composition. Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 080b91d - Browse repository at this point
Copy the full SHA 080b91dView commit details -
settings: add secondary line descriptions for p2p calls and fallbackICE
Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for aee4449 - Browse repository at this point
Copy the full SHA aee4449View commit details -
settings: UX refactor of advanced audio processing options
Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 328c2f3 - Browse repository at this point
Copy the full SHA 328c2f3View commit details
Commits on Oct 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c453176 - Browse repository at this point
Copy the full SHA c453176View commit details
Commits on Oct 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bc4f2b9 - Browse repository at this point
Copy the full SHA bc4f2b9View commit details
Commits on Nov 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d2bb279 - Browse repository at this point
Copy the full SHA d2bb279View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6fb733 - Browse repository at this point
Copy the full SHA f6fb733View commit details -
test: add test for MediaDeviceHandler
Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4187efd - Browse repository at this point
Copy the full SHA 4187efdView commit details
Commits on Nov 9, 2022
-
There are multiple examples of options with null defaults. Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for bf024e2 - Browse repository at this point
Copy the full SHA bf024e2View commit details -
test: add test for VoiceUserSettingsTab
Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 69b1eec - Browse repository at this point
Copy the full SHA 69b1eecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 500c42c - Browse repository at this point
Copy the full SHA 500c42cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.