Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

LLS: Remove beacon info illegal replace relation #8390

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 22, 2022


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8390--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Kerry Archibald added 2 commits April 22, 2022 12:06
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald requested a review from a team as a code owner April 22, 2022 10:41
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #8390 (e526adc) into develop (763edb7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #8390   +/-   ##
========================================
  Coverage    30.47%   30.47%           
========================================
  Files          889      890    +1     
  Lines        50547    50549    +2     
  Branches     12861    12863    +2     
========================================
+ Hits         15405    15407    +2     
  Misses       35142    35142           
Impacted Files Coverage Δ
src/events/EventTileFactory.tsx 66.66% <100.00%> (ø)
src/stores/OwnBeaconStore.ts 97.83% <100.00%> (-0.02%) ⬇️
src/utils/beacon/timeline.ts 100.00% <100.00%> (ø)

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane otherwise

test/utils/beacon/timeline.ts Outdated Show resolved Hide resolved
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald enabled auto-merge (squash) April 22, 2022 11:31
@kerryarchibald kerryarchibald merged commit a3a7c60 into develop Apr 22, 2022
@kerryarchibald kerryarchibald deleted the psf-943/beacon-illegal-replace branch April 22, 2022 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants