Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Live location sharing: maximised view sidebar container #8360

Merged
merged 7 commits into from
Apr 20, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 19, 2022

Empty sidebar for beacon maximised view, nice list elements in next PRs
Only visible behind live location sharing labs flag.

Screenshot 2022-04-19 at 14 54 12

Screenshot 2022-04-19 at 14 54 20

Figma: https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=1662%3A57054


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8360--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Kerry Archibald added 4 commits April 19, 2022 14:44
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 19, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner April 19, 2022 13:02
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #8360 (2c8207a) into develop (a471742) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2c8207a differs from pull request most recent head 07685dc. Consider uploading reports for the commit 07685dc to get more accurate results

@@           Coverage Diff            @@
##           develop    #8360   +/-   ##
========================================
  Coverage    30.05%   30.06%           
========================================
  Files          881      882    +1     
  Lines        50240    50247    +7     
  Branches     12799    12801    +2     
========================================
+ Hits         15099    15106    +7     
  Misses       35141    35141           
Impacted Files Coverage Δ
src/components/views/typography/Heading.tsx 100.00% <ø> (ø)
src/components/views/beacon/BeaconViewDialog.tsx 100.00% <100.00%> (ø)
src/components/views/beacon/DialogSidebar.tsx 100.00% <100.00%> (ø)

Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald enabled auto-merge (squash) April 20, 2022 08:08
@kerryarchibald kerryarchibald merged commit e45cd39 into develop Apr 20, 2022
@kerryarchibald kerryarchibald deleted the psf-930/beacon-dialog-sidebar branch April 20, 2022 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants