Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

use unstable prefix for wk m.tile_server in tests #8316

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 14, 2022


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8316--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald requested a review from a team as a code owner April 14, 2022 08:39
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 14, 2022
@kerryarchibald kerryarchibald changed the title use unstable prefix for wk m.tile_server use unstable prefix for wk m.tile_server in tests Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #8316 (d73f510) into develop (27118a9) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head d73f510 differs from pull request most recent head 0e8a6ed. Consider uploading reports for the commit 0e8a6ed to get more accurate results

@@             Coverage Diff             @@
##           develop    #8316      +/-   ##
===========================================
- Coverage    30.01%   29.83%   -0.18%     
===========================================
  Files          879      874       -5     
  Lines        50193    50025     -168     
  Branches     12783    12729      -54     
===========================================
- Hits         15064    14924     -140     
+ Misses       35129    35101      -28     
Impacted Files Coverage Δ
src/utils/WellKnownUtils.ts 61.76% <100.00%> (ø)
src/autocomplete/EmojiProvider.tsx 16.27% <0.00%> (-72.86%) ⬇️
src/autocomplete/AutocompleteProvider.tsx 0.00% <0.00%> (-60.72%) ⬇️
src/utils/EventUtils.ts 38.20% <0.00%> (-4.51%) ⬇️
src/components/structures/ScrollPanel.tsx 34.47% <0.00%> (-3.71%) ⬇️
src/components/views/elements/AccessibleButton.tsx 34.21% <0.00%> (-2.38%) ⬇️
...ews/settings/tabs/room/SecurityRoomSettingsTab.tsx 0.00% <0.00%> (-0.76%) ⬇️
src/components/structures/MessagePanel.tsx 64.40% <0.00%> (-0.43%) ⬇️
src/utils/permalinks/Permalinks.ts 74.31% <0.00%> (-0.12%) ⬇️
src/components/views/dialogs/InviteDialog.tsx 0.51% <0.00%> (-0.05%) ⬇️
... and 27 more

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - my panic was that we didn't even have an UnstableValue for it, so good to see we have that :D

Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald enabled auto-merge (squash) April 19, 2022 06:49
@kerryarchibald kerryarchibald merged commit 2f32497 into develop Apr 19, 2022
@kerryarchibald kerryarchibald deleted the kerry/unstable-prefix-for-tile-server branch April 19, 2022 06:55
Johennes pushed a commit to Johennes/matrix-react-sdk that referenced this pull request Apr 19, 2022
Signed-off-by: Kerry Archibald <kerrya@element.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants