Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Move RequiresClient from MatrixCapabilities to ElementWidgetCapabilities #8290

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

rkouwenhoven
Copy link
Contributor

@rkouwenhoven rkouwenhoven commented Apr 12, 2022

This PR fixes element-hq/element-web#20920 by moving RequiresClient to the ElementWidgetCapabilities enum.
See also matrix-org/matrix-widget-api#54

I reopened this PR from #7935 to use a different branch.

Please add T-Task label.

Signed-off-by: Robin Kouwenhoven r.kouwenhoven@outlook.com


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8290--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Signed-off-by: Robin Kouwenhoven <r.kouwenhoven@outlook.com>
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #8290 (471eaba) into develop (8eaae6b) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 471eaba differs from pull request most recent head 2f81bc8. Consider uploading reports for the commit 2f81bc8 to get more accurate results

@@             Coverage Diff             @@
##           develop    #8290      +/-   ##
===========================================
- Coverage    29.98%   29.79%   -0.20%     
===========================================
  Files          879      872       -7     
  Lines        50087    50006      -81     
  Branches     12747    12723      -24     
===========================================
- Hits         15017    14897     -120     
- Misses       35070    35109      +39     
Impacted Files Coverage Δ
src/components/views/elements/AppTile.tsx 51.52% <ø> (ø)
src/stores/widgets/StopGapWidgetDriver.ts 0.00% <ø> (ø)
src/autocomplete/EmojiProvider.tsx 16.27% <0.00%> (-72.86%) ⬇️
src/autocomplete/AutocompleteProvider.tsx 0.00% <0.00%> (-60.72%) ⬇️
src/MatrixClientPeg.ts 12.94% <0.00%> (-17.40%) ⬇️
...ews/settings/tabs/room/SecurityRoomSettingsTab.tsx 0.00% <0.00%> (-0.76%) ⬇️
src/components/views/dialogs/InviteDialog.tsx 0.51% <0.00%> (-0.05%) ⬇️
src/RoomInvite.tsx 0.00% <0.00%> (ø)
src/settings/Settings.tsx 63.15% <0.00%> (ø)
src/settings/SettingsStore.ts 58.59% <0.00%> (ø)
... and 19 more

@turt2live turt2live self-requested a review April 12, 2022 14:04
@turt2live turt2live added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 14, 2022
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live enabled auto-merge (squash) April 14, 2022 21:19
@turt2live turt2live merged commit aa33442 into matrix-org:develop Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatrixCapabilities.RequiresClient is in the wrong enum
2 participants