Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Resolve emoji autocomplete not being temporally consistent #8086

Merged
merged 13 commits into from
Apr 14, 2022
Merged

Resolve emoji autocomplete not being temporally consistent #8086

merged 13 commits into from
Apr 14, 2022

Commits on Mar 27, 2022

  1. Adds a test to demonstrate the issue with emoji autocomplete reported… 

    … in element-hq/element-web#19302.

Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    837f916 View commit details
    Browse the repository at this point in the history

  2. Trim trailing : when checking for autocompletes for emoji. 

    Closes element-hq/element-web#19302

Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    02566d6 View commit details
    Browse the repository at this point in the history

  3. Move all references to the emoji delimiter character to reference a c… 

    …onstant.

Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    ac09e71 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Revert "Move all references to the emoji delimiter character to refer… 

    …ence a constant."

This reverts commit ac09e71.

Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    7cd2a97 View commit details
    Browse the repository at this point in the history

  2. Rename variable. 

    Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    da10ca3 View commit details
    Browse the repository at this point in the history

  3. Make the test file a .js file. 

    Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3f8a4fe View commit details
    Browse the repository at this point in the history

  4. Update quotes to match style and make a valid stubbed room. 

    Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    997a5bf View commit details
    Browse the repository at this point in the history

  5. Fix variable name and test reporting. 

    Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    6ebabf1 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into bug/element-web/issues/19302 

    Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    df18446 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Use str.replace with a regex. 

    Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    0317419 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into bug/element-web/issues/19302

    Ryan Browne committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    10d2e3f View commit details
    Browse the repository at this point in the history

  3. Use an improved regex that does not have have to iterate through the … 

    …entire string, and can just backtrack at most the last 2 characters.

Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    220cb0e View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Revert "Use an improved regex that does not have have to iterate thro… 

    …ugh the

entire string, and can just backtrack at most the last 2 characters."

This regex is very efficient, but requires a specific form of the emoji
shortcode that it is not clear is within our control. This is a restriction
that is not required by the technicalities of solving the bug this PR is
attempting to fix. (It requires that an emoji shortcode end with a colon.)

This reverts commit 220cb0e.

Signed-off-by: Ryan Browne <code@commonlawfeature.com>
    Ryan Browne committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    3989a1f View commit details
    Browse the repository at this point in the history