Rephrased inconsistent "ban" in the room space.

[ankur12-1610]

Signed-off-by: ankur12-1610 anknerd.12@gmail.com

Fixes: element-web/20578

Before:

After:

---

Here's what your changelog entry will look like:

🐛 Bug Fixes

• Rephrased inconsistent "ban" in the room space. (#7576). Contributed by @ankur12-1610.

[ankur12-1610]

@HarHarLinks can you review the changes:sweat_smile:?

[HarHarLinks]

Since this touches i18n, this needs to interact with weblate, which I don't know how the workflow is. Might be automatic. However not critical, since the meaning doesn't really change.

[turt2live]

The code is fine, but this needs design review.

[t3chguy]

This will wrongly say Ban from room when looking at a User in the context of a Space.

[turt2live]

@t3chguy doesn't the other one say "Remove from room" for kicks?

[t3chguy]

Yup, its a bug, ideally not one we proliferate

[turt2live]

Hopefully design's review can cover both cases then.

[ankur12-1610]

Hopefully design's review can cover both cases then.

Sorry to disturb but what is the review frequency of the design team:sweat_smile:?

[gaelledel]

As stated in previous comments, there is an issue with the sentence "remove from room" as this does not work for Spaces. Could we use a more general term like "Remove user" so it can apply to both room and spaces scenarios?

[HarHarLinks]

As stated in previous comments, there is an issue with the sentence "remove from room" as this does not work for Spaces. Could we use a more general term like "Remove user" so it can apply to both room and spaces scenarios?

No, since then it is unclear where it might remove the user from. Viewing the member list in a room that is accessible by space members, one might not be certain whether that means room or space. As a server admin, one might even think it deletes the account altogether.

[gaelledel]

As stated in previous comments, there is an issue with the sentence "remove from room" as this does not work for Spaces. Could we use a more general term like "Remove user" so it can apply to both room and spaces scenarios?

No, since then it is unclear where it might remove the user from. Viewing the member list in a room that is accessible by space members, once might not be certain whether that means room or space. As a server admin, one might even think it deletes the account altogether.

Can we programmatically differentiate between Rooms and Spaces? If yes, then I'd prefer options like: Remove from room / Remove from space

[t3chguy]

This was already done by #8281