Use a more generic layout setting - useIRCLayout → layout #5571
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
/me didn't notice it was a draft and got ahead of myself :D |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
changed the title
src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
@jryans Thank you for the review! I've fixed some of the things. Please let me know if the rest is fine this way. |
| @@ -106,6 +114,18 @@ export default class DeviceSettingsHandler extends SettingsHandler { | |||
| return Promise.resolve(); | |||
| } | |||
|
|
|||
| // Special case for old useIRCLayout setting | |||
There was a problem hiding this comment.
Since this is a device only level, is there any need to write the old value? It seems like it would only be needed if you are going back in time to old versions, which seems unlikely. (If it were account level and synced to other devices, we would need it, but that doesn't seem to be the case here.)
There was a problem hiding this comment.
This if statement is here to delete useIRCLayout. Otherwise, the following would always be true:
if (settings["useIRCLayout"]) return Layout.IRC;There was a problem hiding this comment.
Ah okay, fair enough. I suppose alternatively the read path could always check the modern value first and stop there if it exists, but anyway, this seems okay too.
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
| @@ -106,6 +114,18 @@ export default class DeviceSettingsHandler extends SettingsHandler { | |||
| return Promise.resolve(); | |||
| } | |||
|
|
|||
| // Special case for old useIRCLayout setting | |||
There was a problem hiding this comment.
Ah okay, fair enough. I suppose alternatively the read path could always check the modern value first and stop there if it exists, but anyway, this seems okay too.
Reverts part of matrix-org#5571 It's probably quite reasonable to remove this now (after ~6 months) instead of keeping this forever Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This PR converts the
useIRCLayoutsetting to a more genericlayoutsetting. This is a part of the preparations for merging chat-bubbles.