This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Watch for show-RR settings changes, use room-specific and fix margins #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only ever read the global show-RR setting even though it has per-room capabilities, we also never watched it change nor forced a refresh so the user would have to change room/trigger a re-render to see it update and we never collapsed the
margin-right: 110pxwhen its disabled. We do it all now :DFixes element-hq/element-web#4248
look at all that extra space for my UISIs
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com