Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Resolve default export warnings from Webpack #3938

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jan 24, 2020

Webpack was printing several warnings about missing default exports,
particularly from components, where we auto-generate a default import via the
component index.

As part of this, the emoji picker recent handling (which is not a component) is
moved elsewhere to avoid the generated import.

Webpack was printing several warnings about missing default exports,
particularly from components, where we auto-generate a default import via the
component index.

As part of this, the emoji picker recent handling (which is not a component) is
moved elsewhere to avoid the generated import.
@jryans jryans requested a review from a team January 24, 2020 22:29
@jryans
Copy link
Collaborator Author

jryans commented Jan 24, 2020

A sample of the warning output:

2020-01-24 22:09:19.634 [riot-js] WARNING in ../matrix-react-sdk/src/component-index.js 121:0-41
2020-01-24 22:09:19.634 [riot-js] "export 'default' (imported as 'views$auth$InteractiveAuthEntryComponents') was not found in './components/views/auth/InteractiveAuthEntryComponents'
2020-01-24 22:09:19.634 [riot-js]
2020-01-24 22:09:19.634 [riot-js] WARNING in ../matrix-react-sdk/src/component-index.js 121:104-145
2020-01-24 22:09:19.634 [riot-js] "export 'default' (imported as 'views$auth$InteractiveAuthEntryComponents') was not found in './components/views/auth/InteractiveAuthEntryComponents'
2020-01-24 22:09:19.634 [riot-js]
2020-01-24 22:09:19.634 [riot-js] WARNING in ../matrix-react-sdk/src/component-index.js 163:0-31
2020-01-24 22:09:19.634 [riot-js] "export 'default' (imported as 'views$context_menus$TopLeftMenu') was not found in './components/views/context_menus/TopLeftMenu'
2020-01-24 22:09:19.634 [riot-js]
2020-01-24 22:09:19.634 [riot-js] WARNING in ../matrix-react-sdk/src/component-index.js 163:84-115
2020-01-24 22:09:19.634 [riot-js] "export 'default' (imported as 'views$context_menus$TopLeftMenu') was not found in './components/views/context_menus/TopLeftMenu'
2020-01-24 22:09:19.634 [riot-js]
2020-01-24 22:09:19.634 [riot-js] WARNING in ../matrix-react-sdk/src/component-index.js 407:0-24
2020-01-24 22:09:19.634 [riot-js] "export 'default' (imported as 'views$emojipicker$recent') was not found in './components/views/emojipicker/recent'
2020-01-24 22:09:19.634 [riot-js]
2020-01-24 22:09:19.634 [riot-js] WARNING in ../matrix-react-sdk/src/component-index.js 407:70-94
2020-01-24 22:09:19.634 [riot-js] "export 'default' (imported as 'views$emojipicker$recent') was not found in './components/views/emojipicker/recent'

@jryans jryans merged commit ee303b0 into develop Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants