Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix upgraderoom slashcommand #3504

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 1, 2019

Fixes element-hq/element-web#11020

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team October 1, 2019 20:02
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whups, good catch.

I have an eerie feeling this is also present in more places, given:
image

@t3chguy
Copy link
Member Author

t3chguy commented Oct 1, 2019

nope, its just on the new async syntax on Modal, because promises can't return multiple params

@turt2live
Copy link
Member

ah, alright. merging so it sneaks into the release.

@turt2live turt2live merged commit 4c95b20 into develop Oct 1, 2019
@t3chguy t3chguy deleted the t3chguy/fix_upgraderoom_slashcommand branch April 27, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hitting 'Cancel' on room upgrade dialog upgrades the room anyways
2 participants