This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
make the lifetimes of the RM configurable #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
reviewed
Sep 17, 2019
| readMarkerInViewThresholdMs: SettingsStore.getValue("readMarkerInViewThresholdMs"), | ||
|
|
||
| // how long to show the RM for when it's scrolled off-screen | ||
| readMarkerOutOfViewThresholdMs: SettingsStore.getValue("readMarkerOutOfViewThresholdMs"), |
There was a problem hiding this comment.
these won't update without switching between rooms
There was a problem hiding this comment.
correct. does i wonder if this matters though? it's what we do for 12h timestamps etc too.
There was a problem hiding this comment.
well, we should be better at these sorts of things. There's bugs all over the place for "X does not update after changing the setting". They weren't problems before because the timeline would remount after the settings page went away, but now we're a dialog and that causes a whole set of problems.
turt2live
approved these changes
Sep 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on lots of FTUE feedback from Mozilla