Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Ask for the user's password to rehydrate their soft logged out session #3182

Merged
merged 4 commits into from
Jul 9, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jul 4, 2019

Fixes element-hq/element-web#10236

The changes to the MatrixClientPeg (assign/start) are to permit the SoftLogout page to access the MatrixClientPeg reliably. This is why assign() is called by Lifecycle as an alternative to start().

Minimal design work has been done here. The majority is deferred to element-hq/element-web#10262

image

Fixes element-hq/element-web#10236

The changes to the MatrixClientPeg (assign/start) are to permit the SoftLogout page to access the MatrixClientPeg reliably. This is why assign() is called by Lifecycle as an alternative to start().

Minimal design work has been done here. The majority is deferred to element-hq/element-web#10262
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few small things

src/components/structures/auth/SoftLogout.js Show resolved Hide resolved
src/components/structures/auth/SoftLogout.js Show resolved Hide resolved
src/components/structures/auth/SoftLogout.js Show resolved Hide resolved
@turt2live turt2live requested a review from bwindels July 8, 2019 17:51
@turt2live turt2live merged commit 7b869f2 into develop Jul 9, 2019
@turt2live turt2live deleted the travis/soft-logout-rehydrate branch July 9, 2019 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soft logout: Rehydrate session from soft logout page
3 participants