-
-
Notifications
You must be signed in to change notification settings - Fork 829
Use custom appearance and arrow for field selects #2540
Conversation
@@ -99,13 +99,13 @@ limitations under the License. | |||
|
|||
.mx_RoomSubList_chevron { | |||
pointer-events: none; | |||
background-image: url('$(res)/img/topleft-chevron.svg'); | |||
background-repeat: no-repeat; | |||
mask: url('$(res)/img/feather-icons/dropdown-arrow.svg'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, shouldn't we only be putting icons from feather into feather-icons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure what feather-icons
meant at first... I guess it started as icons from https://feathericons.com/. I asked this recently, and I was told it has become a place for other new icons as well, so I placed this one there.
Anyway, we can certainly move it; we just need to agree on what goes in the folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i strongly suggest we only put icons from feathericons.com in feather-icons. whoever said it had become a place for other random icons is confused :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed as element-hq/element-web#8348.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm (other than quibble over the right dir to put the chevron in). thank you!!
merging 'cos i want to use it :) |
Fixes element-hq/element-web#8264.
In addition,
topleft-chevron
is removed and replaced with the similar but simplerdropdown-arrow
.Firefox on macOS:
Chrome on macOS:
Safari on macOS:
Firefox on Windows:
Chrome on Windows: