Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use custom appearance and arrow for field selects #2540

Merged
merged 4 commits into from
Jan 31, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jan 31, 2019

Fixes element-hq/element-web#8264.

In addition, topleft-chevron is removed and replaced with the similar but simpler dropdown-arrow.

Firefox on macOS:

field-select-firefox

Chrome on macOS:

field-select-chrome

Safari on macOS:

safari-macos-field-select

Firefox on Windows:

firefox-windows-field-select

Chrome on Windows:

chrome-windows-field-select

@jryans jryans requested a review from a team January 31, 2019 00:10
@@ -99,13 +99,13 @@ limitations under the License.

.mx_RoomSubList_chevron {
pointer-events: none;
background-image: url('$(res)/img/topleft-chevron.svg');
background-repeat: no-repeat;
mask: url('$(res)/img/feather-icons/dropdown-arrow.svg');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, shouldn't we only be putting icons from feather into feather-icons?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what feather-icons meant at first... I guess it started as icons from https://feathericons.com/. I asked this recently, and I was told it has become a place for other new icons as well, so I placed this one there.

Anyway, we can certainly move it; we just need to agree on what goes in the folder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i strongly suggest we only put icons from feathericons.com in feather-icons. whoever said it had become a place for other random icons is confused :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we can move this one out then. When I asked @bwindels gave the impression that @nadonomy had also added other non-feather icons there, so it may take some detective work to figure out which should actually be there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ara4n ara4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm (other than quibble over the right dir to put the chevron in). thank you!!

@ara4n
Copy link
Member

ara4n commented Jan 31, 2019

merging 'cos i want to use it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants