Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Redesign: pull jump to bottom button out of room status bar #2478

Merged
merged 6 commits into from
Jan 22, 2019

Conversation

bwindels
Copy link
Contributor

element-hq/element-web#7592

jumptobottom2

Also bring back room status bar hiding behaviour, as the status bar will be shown a lot less frequently now so having the layout jump up and down should not be disturbing any more.

@bwindels bwindels requested a review from a team January 22, 2019 13:56
@bwindels
Copy link
Contributor Author

build seems to be failing because it's fetching riot-web@develop to build riot to then run the unit tests, with the file-loader webpack configuration missing on develop ... save to ignore.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm barring question about a comment being removed

src/components/structures/RoomStatusBar.js Show resolved Hide resolved
@bwindels bwindels merged commit d803005 into experimental Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants