This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Redesign: Add (+) button in room section header to add rooms #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way, we'll be able to add adjacent resize handles and scroll wrappers
works with the flex-grow we set initially for the sub lists
|
1st go at it, not pixel perfect yet. Needs an SVG icon instead of text + sign, other design tweaks, ... |
|
build still breaking because e2e can't find create room button btw. Although technically, this PR could fix that as it reintroduces the functionality, making the markup compatible with the tests is a pain. So leaving them broken for now. Maybe it would make sense to disable e2e test for the redesign as there are a lot of brittle selectors in there? and then fix them all once we're ready to switch to new design? Rather this than breaking the e2e tests on develop I think. |
dbkr
approved these changes
Oct 22, 2018
|
and yeah, disabling e2e tests for the duration of the redesign makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #2226 being merged first.
Part of element-hq/element-web#7161