Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Show the group member list again #2223

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Show the group member list again #2223

merged 3 commits into from
Oct 23, 2018

Conversation

turt2live
Copy link
Member

@turt2live turt2live requested a review from a team October 17, 2018 01:15
bwindels
bwindels reviewed Oct 17, 2018
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to make this css class completely obsolete. Clean up the usage of this class in GroupMemberList::render & MemberList::render?

@turt2live
Copy link
Member Author

Part of me wants to just leave it there for not-riot to override the CSS of, but I'm not sure what we normally do in this case.

@bwindels
Copy link
Contributor

Good question. @dbkr any input what the historical take has been to remove css classes not used anymore in the SDK?

@turt2live turt2live requested a review from dbkr October 18, 2018 14:50
@dbkr
Copy link
Member

dbkr commented Oct 22, 2018

I would probably remove them: especially for something somewhat random like this.

@turt2live turt2live requested review from a team and removed request for dbkr October 22, 2018 21:14
@dbkr dbkr merged commit 5206719 into develop Oct 23, 2018
@turt2live turt2live deleted the travis/fix-group-members branch October 23, 2018 14:18
@turt2live turt2live mentioned this pull request Oct 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwindels bwindels bwindels left review comments

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turt2live @bwindels @dbkr