This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Ignore desktop for minimum browser support. #12928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Defect
dbkr
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
I think this makes sense. Perhaps we could add a comment on our conclusion from the weekly that you might get distros bundling another version of electron, but it probably doesn't make sense to warn the user in this case.
We should also check with @t3chguy but I think we can merge this for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Closes element-hq/element-desktop#1828
The element web team discussed about it. We decided to remove it from desktop since it's making more harm than good in this case.
Two uses cases: