This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Clear settings caches on reset rather than custom lifecycle method #12859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
added
the
T-Defect
Closed
dbkr
reviewed
Aug 2, 2024
|
|
||
| public reset(): void { | ||
| AbstractLocalStorageSettingsHandler.clear(); | ||
| AbstractLocalStorageSettingsHandler.clear(); |
There was a problem hiding this comment.
is this supposed to be calling the same thing twice?
There was a problem hiding this comment.
Turns out Lifecycle already had a custom clear method it called, wired it up to the standard SettingsHandler::reset which exists now instead, turns out this was only an issue for tests so changing the T
t3chguy
changed the title
t3chguy
added
T-Task
dbkr
approved these changes
Aug 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.