This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Clean up editor drafts for unknown rooms #12850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langleyd
added
the
T-Enhancement
t3chguy
reviewed
Jul 31, 2024
| @@ -1542,6 +1543,8 @@ export default class MatrixChat extends React.PureComponent<IProps, IState> { | |||
| showNotificationsToast(false); | |||
| } | |||
|
|
|||
| cleanUpDraftsIfRequired(); | |||
There was a problem hiding this comment.
I think this point in the code is executed at the point we load the sync accumulator also, rather than just after the first real sync
t3chguy
approved these changes
Aug 5, 2024
|
Looks like the code coverage is insufficient |
…rg/matrix-react-sdk into langleyd/cleanup_drafts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Periodically clean up editor drafts for rooms that are not in our list of known rooms, when the client is in a good state(directly after a sync).