Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make widget tests throw when a modal is shown #12834

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Make widget tests throw when a modal is shown #12834

merged 1 commit into from
Aug 8, 2024

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Jul 29, 2024

Instead of waiting for tests to time out if they show a dialog that they cannot interact with, throw an error immediately if a dialog is shown.

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@AndrewFerr AndrewFerr requested a review from a team as a code owner July 29, 2024 12:36
@AndrewFerr AndrewFerr requested review from dbkr and t3chguy July 29, 2024 12:36
@AndrewFerr AndrewFerr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 29, 2024
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not match its title. The test is not responsible for making the app fail fast

@AndrewFerr AndrewFerr changed the title Fail fast when capabilities are missing Make widget tests fail faster when capabilities are missing Jul 29, 2024
@AndrewFerr AndrewFerr changed the title Make widget tests fail faster when capabilities are missing Make widget tests throw when a modal is shown Jul 29, 2024
@AndrewFerr AndrewFerr requested a review from t3chguy July 29, 2024 12:48
Instead of waiting for tests to time out if they show a dialog that they
cannot interact with, throw an error immediately if a dialog is shown.
@t3chguy
Copy link
Member

t3chguy commented Aug 8, 2024

@AndrewFerr do you need me to hit the merge button or are you able to yourself?

@AndrewFerr
Copy link
Member Author

@AndrewFerr do you need me to hit the merge button or are you able to yourself?

The former, as I currently don't have write access to this repo.

@t3chguy t3chguy added this pull request to the merge queue Aug 8, 2024
Merged via the queue into matrix-org:develop with commit ff15249 Aug 8, 2024
26 checks passed
@AndrewFerr AndrewFerr deleted the test-fail-fast-on-modal branch August 8, 2024 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants