Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix widgets not being cleaned up correctly. #12616

Merged
merged 3 commits into from
Jun 17, 2024

Commits on Jun 13, 2024

  1. Fix widgets not being cleaned up correctly.

    Widgets could persist forever because they were still sticky when we end the messaging.
    Ending the messaging emits an event to which we connect ui changes that move the widget out of the screen. It does not end up in a pip view however.
    
    So we need to make sure the widget is not persistend anymore when we call `stopMessagingByUid` so that any dom changes that remove the AppTile happen when the widget is not persistend anymore and let it destroy.
    
    This PR also makes the role for `MatrixRTCSessionManager` more strict. We do ONLY use it in `Call.ts` and `CallStore`  so that we dont end up in reaces where we updated the ui based on the session manager but not in sync with the call and callstore changes.
    
    Rename activeCalls to connectedCalls. Active call can also be understood as a call where there are active participants but the user itself is not connected. Especially with the `hasActiveCallSession` field of the useRoomCall hook which is tracking active (not necassarly connected sessions)
    toger5 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    4c77a7c View commit details
    Browse the repository at this point in the history
  2. rest of the renaming

    toger5 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    036937e View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Configuration menu
    Copy the full SHA
    10074d3 View commit details
    Browse the repository at this point in the history