Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make micIcon display on primary #11908

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

kdanielm
Copy link
Contributor

@kdanielm kdanielm commented Nov 20, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This is a minor change fixing a small bug in the call window for element web and desktop. The mic status of the other participant in a 1:1 call is only shown on the secondary screen, but missing on the primary screen, causing confusion between parties. Proper status reflection was tested with calls between element-web / desktop.
(Android client currently does not seem to send an event when muting / unmuting unlike the web variants. I'll have a look at that somewhen later as well)

Screenshot:

image

No new test was written for this (very) small change.

Notes: Properly display mic icon on primary view in 1:1 call to see muted state of other participant

Type: defect

Signed-off-by: Kai Danielmeier kai.danielmeier@gmail.com


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Properly display mic icon on primary view in 1 (#11908). Contributed by @kdanielm.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Nov 20, 2023
@kdanielm kdanielm marked this pull request as ready for review November 20, 2023 09:22
@kdanielm kdanielm requested a review from a team as a code owner November 20, 2023 09:22
@weeman1337 weeman1337 requested review from weeman1337 and removed request for richvdh November 28, 2023 08:18
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Showing the microphone indicator in non-primary should be okay.
A quick test on the deployment worked ✔️

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Jul 29, 2024
Merged via the queue into matrix-org:develop with commit 96777f8 Jul 29, 2024
26 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants