Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

unit test leave_room action handler #10982

Merged
merged 2 commits into from
May 30, 2023
Merged

unit test leave_room action handler #10982

merged 2 commits into from
May 30, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented May 25, 2023 •
edited by github-actions bot
Loading

In preparation for extracting this logic into a util

For element-hq/element-web#23529

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 25, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review May 25, 2023 05:48
@kerryarchibald kerryarchibald requested a review from a team as a code owner May 25, 2023 05:48
@kerryarchibald kerryarchibald enabled auto-merge May 30, 2023 22:18
@kerryarchibald kerryarchibald added this pull request to the merge queue May 30, 2023
Merged via the queue into develop with commit ef8719a May 30, 2023
@kerryarchibald kerryarchibald deleted the kerry/23529/test-room-actions branch May 30, 2023 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @weeman1337