Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix: cypress findByTestId and percySnapshotElement do not work together #10947

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Fix: cypress findByTestId and percySnapshotElement do not work together #10947

merged 8 commits into from
Jul 14, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented May 19, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#25391

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue labels May 19, 2023
@kerryarchibald kerryarchibald mentioned this pull request May 19, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald marked this pull request as ready for review May 19, 2023 02:29
@kerryarchibald kerryarchibald requested a review from a team as a code owner May 19, 2023 02:29
@kerryarchibald kerryarchibald added this pull request to the merge queue May 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2023
@kerryarchibald kerryarchibald force-pushed the kerry/25391/findbytestid-snapshot branch from bbb0cd7 to f7a8bc9 Compare May 23, 2023 07:26
@luixxiul luixxiul mentioned this pull request May 26, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald marked this pull request as draft May 28, 2023 22:21
t3chguy
t3chguy approved these changes Jul 14, 2023
View reviewed changes
cypress/support/percy.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy marked this pull request as ready for review July 14, 2023 10:50
@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2023

Running a percy test

@t3chguy t3chguy added this pull request to the merge queue Jul 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2023

That unfortunately still did not work

@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2023

Somehow my earlier change didn't take effect so the test was invalid

@t3chguy t3chguy enabled auto-merge July 14, 2023 11:31
@t3chguy t3chguy added this pull request to the merge queue Jul 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2023

image

Yay

@t3chguy t3chguy removed the X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue label Jul 14, 2023
@t3chguy t3chguy enabled auto-merge July 14, 2023 13:27
@t3chguy t3chguy added this pull request to the merge queue Jul 14, 2023
Merged via the queue into develop with commit eced103 Jul 14, 2023
23 checks passed
@t3chguy t3chguy deleted the kerry/25391/findbytestid-snapshot branch July 14, 2023 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@weeman1337 weeman1337 weeman1337 approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
3 participants
@kerryarchibald @t3chguy @weeman1337