Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Apply strictNullChecks to src/components/views/rooms/wysiwyg_composer/* #10653

Merged
merged 5 commits into from
May 5, 2023
Merged

Apply strictNullChecks to src/components/views/rooms/wysiwyg_composer/* #10653

merged 5 commits into from
May 5, 2023

Conversation

alunturner
Copy link
Contributor

@alunturner alunturner commented Apr 18, 2023 •
edited by github-actions bot
Loading

Closes element-hq/element-web#24941.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@alunturner alunturner changed the title Alunturner/wysiwyg strict null checks Apply strictNullChecks to src/components/views/rooms/wysiwyg_composer/* Apr 18, 2023
@alunturner alunturner added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 18, 2023
@alunturner alunturner marked this pull request as ready for review April 27, 2023 09:01
@alunturner alunturner requested a review from a team as a code owner April 27, 2023 09:01
kerryarchibald
kerryarchibald approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alunturner alunturner added this pull request to the merge queue May 5, 2023
Merged via the queue into develop with commit c824c4a May 5, 2023
@alunturner alunturner deleted the alunturner/wysiwyg-strict-null-checks branch May 5, 2023 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply strictNullChecks to src/components/views/rooms/wysiwyg_composer/*
2 participants
@alunturner @kerryarchibald