Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix create subspace dialog not working #10652

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix create subspace dialog not working #10652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/components/views/dialogs/CreateSubspaceDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,22 @@ const CreateSubspaceDialog: React.FC<IProps> = ({ space, onAddExistingSpaceClick

const onCreateSubspaceClick = async (e: ButtonEvent): Promise<void> => {
e.preventDefault();
if (busy || !spaceNameField.current || !spaceAliasField.current) return;
if (busy) return;

setBusy(true);
// require & validate the space name field
if (!(await spaceNameField.current.validate({ allowEmpty: false }))) {
if (spaceNameField.current && !(await spaceNameField.current.validate({ allowEmpty: false }))) {
spaceNameField.current.focus();
spaceNameField.current.validate({ allowEmpty: false, focused: true });
setBusy(false);
return;
}
// validate the space name alias field but do not require it
if (joinRule === JoinRule.Public && !(await spaceAliasField.current.validate({ allowEmpty: true }))) {
if (
spaceAliasField.current &&
joinRule === JoinRule.Public &&
(await spaceAliasField.current.validate({ allowEmpty: true }))
) {
spaceAliasField.current.focus();
spaceAliasField.current.validate({ allowEmpty: true, focused: true });
setBusy(false);
Expand Down