Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make test ID compatible with findByTestId() of Cypress Testing Library #10617

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Make test ID compatible with findByTestId() of Cypress Testing Library #10617

merged 1 commit into from
Apr 17, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 15, 2023

Closes element-hq/element-web#25116

This PR intends to make test IDs compatible with findByTestId() of Cypress Testing Library by replacing data-test-id with data-testid.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

'data-test-id' is not discoverable with findByTestId() of Cypress Testing Library.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 15, 2023
@luixxiul luixxiul marked this pull request as ready for review April 15, 2023 06:23
@luixxiul luixxiul requested a review from a team as a code owner April 15, 2023 06:23
@luixxiul luixxiul requested review from justjanne and robintown April 15, 2023 06:23
@kerryarchibald kerryarchibald added this pull request to the merge queue Apr 17, 2023
Merged via the queue into matrix-org:develop with commit 8a4a584 Apr 17, 2023
@luixxiul luixxiul deleted the test-id-findByTestId branch April 17, 2023 07:54
@luixxiul
Copy link
Contributor Author

Thanks for the review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all data test IDs compatible with Cypress Testing Library
2 participants