This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add ESLint Jest #10261
Merged
Add ESLint Jest #10261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
added
the
T-Task
weeman1337
force-pushed
the
weeman1337/jest-eslint
branch
from
cb15afc to
a44554f
Compare
t3chguy
reviewed
Mar 1, 2023
Comment on lines
298
to
299
| // TODO: We currently can’t test finding rooms on other homeservers/other protocols | ||
| // We obviously don’t have federation or bridges in cypress tests |
There was a problem hiding this comment.
cy.intercept is a thing, not sure why we "can't"
Unrelated to this PR off
t3chguy
approved these changes
Mar 1, 2023
This was referenced Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be reviewed commit wise.
This is a start. Uses the same Jest rules as JS SDK which was added in matrix-org/matrix-js-sdk#2973
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.