Merge pull request #3024 from matrix-org/bwindels/autocomplete-tab

Message editing: tab completion
matrix-org · May 24, 2019 · 9d6a818 · 9d6a818
2 parents 3c778e8 + cf5e4d3
commit 9d6a818
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/src/editor/autocomplete.js b/src/editor/autocomplete.js
@@ -39,8 +39,24 @@ export default class AutocompleteWrapperModel {
         this._updateCallback({close: true});
     }
 
-    onTab() {
-        //forceCompletion here?
+    async onTab(e) {
+        const acComponent = this._getAutocompleterComponent();
+
+        if (acComponent.state.completionList.length === 0) {
+            // Force completions to show for the text currently entered
+            await acComponent.forceComplete();
+            // Select the first item by moving "down"
+            await acComponent.onDownArrow();
+        } else {
+            if (e.shiftKey) {
+                await acComponent.onUpArrow();
+            } else {
+                await acComponent.onDownArrow();
+            }
+        }
+        this._updateCallback({
+            close: true,
+        });
     }
 
     onUpArrow() {

diff --git a/src/editor/parts.js b/src/editor/parts.js
@@ -313,8 +313,16 @@ export class PillCandidatePart extends PlainPart {
         return this._autoCompleteCreator(updateCallback);
     }
 
-    acceptsInsertion(chr) {
-        return true;
+    acceptsInsertion(chr, i) {
+        if (i === 0) {
+            return true;
+        } else {
+            return super.acceptsInsertion(chr, i);
+        }
+    }
+
+    merge() {
+        return false;
     }
 
     acceptsRemoval(position, chr) {