Add a function to flag keys for backup without scheduling a backup #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For element-hq/element-web#10263 Starting/scheduling the backup won't help us because the token would be invalid from a server perspective. Instead, we should update what needs to be done and return a count.
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jul 5, 2019
bwindels
approved these changes
Jul 8, 2019
| * them to upload in the background. | ||
| * @returns {Promise<int>} Resolves to the number of sessions requiring a backup. | ||
| */ | ||
| MatrixClient.prototype.flagAllGroupSessionsForBackup = function() { |
There was a problem hiding this comment.
the API of this method is a bit confusing, as it seems both query and command, but I guess the reason will become clear once I see the usage for it in the next PR :)
There was a problem hiding this comment.
it is a bit confusing, but I'd argue it's no worse than select * from x telling you how many rows it fetched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#10263 / matrix-org/matrix-react-sdk#3187
Starting/scheduling the backup won't help us because the token would be invalid from a server perspective. Instead, we should update what needs to be done and return a count.