Re-send MatrixRTC media encryption keys for a new joiner even if a rotation is in progress #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation is in progress
toger5
approved these changes
Nov 28, 2024
Comment on lines
896
to
905
| this.storeLastMembershipFingerprints(); | ||
|
|
||
| if (anyLeft) { | ||
| logger.debug(`Member(s) have left: queueing sender key rotation`); | ||
| this.makeNewKeyTimeout = setTimeout(this.onRotateKeyTimeout, this.makeKeyDelay); | ||
| if (this.makeNewKeyTimeout) { | ||
| // existing rotation in progress, so let it complete | ||
| } else { | ||
| logger.debug(`Member(s) have left: queueing sender key rotation`); | ||
| this.makeNewKeyTimeout = setTimeout(this.onRotateKeyTimeout, this.makeKeyDelay); | ||
| } | ||
| } else if (anyJoined) { |
There was a problem hiding this comment.
Even though this could be:
if (anyLeft && !this.makeNewKeyTimeout)
I very much like the readability this way has.
toger5
deleted the
hughns/matrixrtc-resend-keys-on-join-even-with-rotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.