Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MatrixClient::forget to not abuse membershipChange API #4490

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Refactor MatrixClient::forget to not abuse membershipChange API #4490

merged 1 commit into from
Nov 4, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 31, 2024

@t3chguy
Refactor MatrixClient::forget to not abuse membershipChange API
a0e6d9e 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Oct 31, 2024
@t3chguy t3chguy self-assigned this Oct 31, 2024
@t3chguy t3chguy marked this pull request as ready for review October 31, 2024 12:44
@t3chguy t3chguy requested a review from a team as a code owner October 31, 2024 12:44
@t3chguy t3chguy requested review from dbkr and MidhunSureshR October 31, 2024 12:44
@t3chguy t3chguy added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit a197afe Nov 4, 2024
31 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/17510 branch November 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forget calls a membershipChange of 'forget'
2 participants
@t3chguy @dbkr