Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we do not add relations to the wrong timeline #3427

Merged
merged 19 commits into from
Jun 1, 2023
Merged

Ensure we do not add relations to the wrong timeline #3427

merged 19 commits into from
Jun 1, 2023

Commits on May 31, 2023

  1. Do not assume that a relation lives in main timeline if we do not kno… 

    …w its parent
    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8ecc696 View commit details
    Browse the repository at this point in the history

  2. For pagination, partition relations with unknown parents into a separ… 

    …ate bucket

And only add them to relation map, no timelines
    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    062ab5f View commit details
    Browse the repository at this point in the history

  3. Make addLiveEvents async and have it fetch parent events of unknown r… 

    …elations to not insert into the wrong timeline
    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8150040 View commit details
    Browse the repository at this point in the history

  4. Fix tests not awaiting addLIveEvents

    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    61eb1d5 View commit details
    Browse the repository at this point in the history

  5. Fix handling of thread roots in eventShouldLiveIn

    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4ae5820 View commit details
    Browse the repository at this point in the history

  6. Fix types

    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    2afd31f View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    bfe3a08 View commit details
    Browse the repository at this point in the history

  8. Fix import

    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    2d6ee39 View commit details
    Browse the repository at this point in the history

  9. Stash thread ID of relations in unsigned to be stashed in sync accumu… 

    …lator
    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    bd8d7e5 View commit details
    Browse the repository at this point in the history

  10. Persist after processing

    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    05ed640 View commit details
    Browse the repository at this point in the history

  11. Revert "Persist after processing" 

    This reverts commit 05ed640.
    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8e323ba View commit details
    Browse the repository at this point in the history

  12. Update unsigned field name to match MSC4023

    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5bdbb4d View commit details
    Browse the repository at this point in the history

  13. Persist after processing to store thread id in unsigned sync accumulator

    @t3chguy
    t3chguy committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c0a2cef View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Add test

    @t3chguy
    t3chguy committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    2dd21c7 View commit details
    Browse the repository at this point in the history

  2. Fix replayEvents getting doubled up due to Thread::addEvents being ca… 

    …lled in createThread and separately
    @t3chguy
    t3chguy committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    bad9cc2 View commit details
    Browse the repository at this point in the history

  3. Fix test

    @t3chguy
    t3chguy committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    a920630 View commit details
    Browse the repository at this point in the history

  4. Switch to using UnstableValue

    @t3chguy
    t3chguy committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    55566a7 View commit details
    Browse the repository at this point in the history

  5. Add comment

    @t3chguy
    t3chguy committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    660627f View commit details
    Browse the repository at this point in the history

  6. Iterate

    @t3chguy
    t3chguy committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    156fcff View commit details
    Browse the repository at this point in the history