Add prefer-const #331
Merged
Add prefer-const #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our code style says we prefer consts, so add it to the linter.
|
pfff. 1860 warnings is a bit much to be dealing with.
|
|
I agree with it being annoying being forced into particular things, although consts can help prevent bug, so could be useful. Running --fix seems to do sensible things, so happy to add that. |
richvdh
requested changes
Jan 19, 2017
| @@ -11,7 +11,7 @@ | |||
| "build": "babel -s -d lib src && rimraf dist && mkdir dist && browserify --exclude olm browser-index.js -o dist/browser-matrix.js --ignore-missing && uglifyjs -c -m -o dist/browser-matrix.min.js dist/browser-matrix.js", | |||
| "dist": "npm run build", | |||
| "watch": "watchify --exclude olm browser-index.js -o dist/browser-matrix-dev.js -v", | |||
| "lint": "eslint --max-warnings 122 src spec", | |||
| "lint": "eslint --max-warnings 1860 src spec", | |||
and make prefer-const an error
richvdh
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code style says we prefer consts, so add it to the linter.