Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch some imports to type imports #3250

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Switch some imports to type imports #3250

merged 1 commit into from
Apr 4, 2023

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 4, 2023 •
edited by github-actions bot
Loading

Having these as regular imports confuses Vite for some reason.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr
Switch some imports to type imports
9c24df0 
Having these as regular imports confuses Vite for some reason.
@dbkr dbkr added the T-Task Tasks for the team like planning label Apr 4, 2023
@dbkr dbkr requested a review from a team as a code owner April 4, 2023 15:21
@dbkr dbkr requested review from t3chguy and justjanne April 4, 2023 15:21
t3chguy
t3chguy approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webpack was complaining too FTR

@dbkr dbkr added this pull request to the merge queue Apr 4, 2023
Merged via the queue into develop with commit d05313f Apr 4, 2023
@dbkr dbkr deleted the dbkr/crypto_api_type_imports branch April 4, 2023 15:55
@richvdh richvdh mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @t3chguy