BREAKING CHANGE: Remove WebStorageStore #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be replaced with an IndexedDB style solution. Maintaining 2 different persistent stores is not my idea of fun.
…onst, function, class) not yet supported outside strict mode'
dbkr
approved these changes
Jan 13, 2017
dbkr
requested changes
Jan 13, 2017
|
I thought about this but it will be automatically populated based off the title of this PR, which is why I used shouty-caps. I feel this is probably clear enough? |
|
Possibly - we normally break it out into a separate 'breaking changes' section. Maybe this is fine though. |
|
Well let me know either way, I don't really mind which. |
dbkr
approved these changes
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be replaced with an IndexedDB style solution. Maintaining 2 different
persistent stores is not my idea of fun.