Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore m.replace relations on state events, they're invalid #2306

Merged
merged 6 commits into from
Apr 26, 2022
Merged

Ignore m.replace relations on state events, they're invalid #2306

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65c6801
Ignore m.replace relations on state events, they're invalid
t3chguy Apr 20, 2022
de5c343
Add tests
t3chguy Apr 20, 2022
d23ae9f
Fix test
t3chguy Apr 20, 2022
08bca17
Merge branch 'develop' into t3chguy/fix/21851
t3chguy Apr 20, 2022
3db907e
Merge branch 'develop' into t3chguy/fix/21851
t3chguy Apr 20, 2022
949bb40
Merge branch 'develop' into t3chguy/fix/21851
Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/models/event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,10 @@ export class MatrixEvent extends TypedEventEmitter<EmittedEvents, MatrixEventHan
if (this.isRedacted() && newEvent) {
return;
}
// don't allow state events to be replaced using this mechanism as per MSC2676
if (this.isState()) {
t3chguy marked this conversation as resolved.
Show resolved Hide resolved
return;
}
if (this._replacingEvent !== newEvent) {
this._replacingEvent = newEvent;
this.emit(MatrixEventEvent.Replaced, this);
Expand Down