Make events pagination responses parse threads #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
Nov 4, 2021
| const [timelineEvents, threadedEvents] = this.partitionThreadedEvents(matrixEvents); | ||
|
|
||
| room.addEventsToTimeline(timelineEvents, true, room.getLiveTimeline()); | ||
| this.processThreadEvents(room, threadedEvents); |
There was a problem hiding this comment.
There's probably some way we can refine this in the future to avoid repeating processThreadEvents everywhere, but anyway it's okay for now.
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Nov 24, 2021
* Fix edit history being broken after editing an unencrypted event with an encrypted event ([\matrix-org#2013](matrix-org#2013)). Fixes element-hq/element-web#19651 and element-hq/element-web#19651. Contributed by @aaronraimist. * Make events pagination responses parse threads ([\matrix-org#2011](matrix-org#2011)). Fixes element-hq/element-web#19587 and element-hq/element-web#19587.
skyka13711
pushed a commit
to 42-px/matrix-js-sdk
that referenced
this pull request
Apr 14, 2022
skyka13711
pushed a commit
to 42-px/matrix-js-sdk
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#19587
Possible will do the trick for element-hq/element-web#19607 & element-hq/element-web#19603
Here's what your changelog entry will look like:
🐛 Bug Fixes