-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give CallFeed
the capability to emit on volume changes
#1865
Give CallFeed
the capability to emit on volume changes
#1865
Conversation
6de626d
to
69e16d1
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
69e16d1
to
22cd475
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It might be nice to actually shift more of this towards the js-sdk side and have it emit active-speaker events so the js-sdk handles the threshold etc rather than just throwing volume events at the app. Also unsure if we'll want to highlight all people who are actively speaking or just decide which person is the active speaker (like jitsi does). In a way I sort of like highlighting all the people we think are speaking, but probably a product call.
It was intentional in case some other app building on the js-sdk can access the volume directly but we can emit both
Agreed, I would also prefer highlighting all speaking users. Guessing the main speaker feels a bit useless now and it doesn't feel like an important thing to have. We can always add it in the future. Figma also seems to agree: When a user speaks, its videofeed should be highlighted in Accent colour |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Type: enhancement
For matrix-org/matrix-react-sdk#6639
To be transparent, I have no idea what I am doing but it seems to work 😅
Here's what your changelog entry will look like:
✨ Features
CallFeed
the capability to emit on volume changes (#1865). Contributed by SimonBrandner.