Add option to allow users of pantialaimon to use the SDK #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/usingE2EProxy-flag
branch
from
4aeecc8 to
e201aab
Compare
jryans
requested changes
Sep 16, 2020
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
jryans
approved these changes
Sep 16, 2020
jryans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-js-sdk will block attempts to send events to encrypted rooms by default if you've not enabled the crypto parts of the library. There are special reasons for which I need to use Pantalaimon as a proxy for some bridge work, so I need the SDK to not block attempts in this case, as the upstream library will take care of it.
I'd like to propose this flag to let developers opt to ignore such warnings. I also couldn't really decide upon a flag name, so suggestions welcome!