Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax identity server discovery checks to FAIL_PROMPT #1062

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Nov 1, 2019

As discussed in MSC2284, this relaxes the identity server discovery to a
FAIL_PROMPT state so that clients can choose to warn and continue.

Part of element-hq/element-web#11102
Implements matrix-org/matrix-spec-proposals#2284

As discussed in MSC2284, this relaxes the identity server discovery to a
`FAIL_PROMPT` state so that clients can choose to warn and continue.

Part of element-hq/element-web#11102
Implements matrix-org/matrix-spec-proposals#2284
@jryans jryans requested a review from turt2live November 1, 2019 12:31
@jryans
Copy link
Collaborator Author

jryans commented Nov 1, 2019

Still need to fix the failing tests... As part of that, I am trying find out why the BK log doesn't show the test summary.

@jryans
Copy link
Collaborator Author

jryans commented Nov 1, 2019

Okay, tests should be passing now. I'll continue to explore the test log problem separately.

@turt2live
Copy link
Member

We need to get the MSC across the line before we can merge this. Our new spec process doesn't allow us to move quickly for .well-known

@jryans
Copy link
Collaborator Author

jryans commented Nov 1, 2019

Fair enough, I'll mark the issue blocked then.

@jryans
Copy link
Collaborator Author

jryans commented Nov 1, 2019

(It would still be good to review the code, even if we can't merge it yet.)

@jryans jryans force-pushed the jryans/identity-disco-opt branch from 72f3e04 to 91df096 Compare November 1, 2019 14:42
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code largely seems fine (and yes, I do agree with the changes but the spec process is dumb for cases like this)

@jryans
Copy link
Collaborator Author

jryans commented Nov 1, 2019

@turt2live What phase of the spec process do we need to wait for in this case?

@turt2live
Copy link
Member

Release with a formal version number.

@turt2live
Copy link
Member

unless we fix the process, of course.

@jryans
Copy link
Collaborator Author

jryans commented Nov 25, 2019

From element-hq/element-web#11102, it was decided it was safe to merge this work once we cleared FCP.

@jryans
Copy link
Collaborator Author

jryans commented Nov 25, 2019

This PR was accidentally forgotten... It doesn't appear to be required for React SDK / Riot to process a dead IS as optional, but that's more of a curiosity of how it interprets discovery results. This work is the key of implementing the MSC text as written and work be important for any other uses of JS SDK.

@jryans
Copy link
Collaborator Author

jryans commented Nov 26, 2019

It turns out this side was more important than I remembered... 😞 In particular, it's needed at least for the startup autodiscovery, so that we don't show a hard error as in element-hq/element-web#11508.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants