Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bridge to be compatible with matrix-appservice-bridge 2.0 #491

Merged
merged 8 commits into from
Sep 18, 2020

Conversation

Half-Shot
Copy link
Contributor

As we did with the IRC bridge, this is just to ensure that we remain compatible in a typed world.

@Half-Shot Half-Shot force-pushed the hs/move-to-typed-bridge-lib branch from cd22a58 to 20076a6 Compare September 16, 2020 17:53
@Half-Shot Half-Shot changed the title WIP: Refactor bridge to be compatible with matrix-appservice-bridge 2.0 Refactor bridge to be compatible with matrix-appservice-bridge 2.0 Sep 16, 2020
@Half-Shot Half-Shot requested a review from a team September 16, 2020 17:53
@jaller94 jaller94 removed the request for review from a team September 17, 2020 08:36
@jaller94
Copy link
Contributor

Basically all CI tests failed and there's a merge conflict. I think this needs to go back into "In Progress".

@Half-Shot
Copy link
Contributor Author

Yeah it usually helps if I remember to merge :/

@Half-Shot Half-Shot requested a review from jaller94 September 17, 2020 09:09
@Half-Shot Half-Shot mentioned this pull request Sep 17, 2020
4 tasks
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all sensible.

@jaller94 jaller94 merged commit 4fa3b69 into develop Sep 18, 2020
@jaller94 jaller94 deleted the hs/move-to-typed-bridge-lib branch September 21, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants