Show a preview of long messages on IRC #529
Conversation
14mRh4X0r
force-pushed
the
show-first-line
branch
from
05e9552 to
51d82de
Compare
|
How does this handle pure code blocks? Edit: to elaborate, a message containing only a code block (starting and ending with |
14mRh4X0r
force-pushed
the
show-first-line
branch
from
51d82de to
b50589f
Compare
|
This will need rebasing onto the current develop because we dropped node 4 :(. Also, unit tests on the behavior would be good. |
14mRh4X0r
force-pushed
the
show-first-line
branch
from
b50589f to
9de711a
Compare
|
Thanking you, will review. |
| @@ -133,6 +133,56 @@ function Client(addr, nick, opts) { | |||
| return this.chans[channel]; | |||
| } | |||
|
|
|||
| // Copied over from irc.js and modified slightly | |||
There was a problem hiding this comment.
Not a huge fan of this, but it looks like the IRC lib for some reason contains code that really aught to be split out. I'll allow it.
There was a problem hiding this comment.
Actually, crazy idea. Could we put these two functions in a new class in util/MessageFormatting.js or something rather than using the unsafeClient version. I think it would be better than reimplementing them in a mock.
| msgtype: "m.text", | ||
| body: messagePreview + truncatedMsg | ||
| }; | ||
| } | ||
| } | ||
| else { | ||
| req.log.warn("Sending truncated message"); |
There was a problem hiding this comment.
Small complaint: This should probably be info rather than warn. I know you didn't write the code, but it's just annoying me 😆
|
I think this is looking very promising, if we fix these up I'll take another look and hopefully merge :) |
|
Since our move to Typescript, this PR will no longer cleanly merge into the codebase. I'm going to close this rather than request changes. Feel free to re-open the PR if you want to continue to work on it. |
|
Bringing this back in #1430 since it's still an annoying issue for IRC users. Thanks for contributing it, @14mRh4X0r! |
This gives users on the IRC side an idea what the long message is about, without flooding the channel with text. This solves an issue some people have where IRC users aren't willing to click to content they can't see, and is more in line with other services.