Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Fix / partially shared session #446

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Fix / partially shared session #446

merged 2 commits into from
Mar 25, 2019

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Mar 20, 2019 •
edited
Loading

Fixes element-hq/riot-android#3044

  • Support adding/importing new version of known olm session if chain index lower (if pre racheted key has been imported earlier).
  • Added some missing jni release
  • Prevent a potential infinite loop of key sharing request when received key not accepted (new session event was fired even if key was not accepted, thus firing again key share requests)

@BillCarsonFr BillCarsonFr requested review from bmarty and manuroe March 20, 2019 15:19
manuroe
manuroe approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty force-pushed the feature/fix_partial_keyshare branch from 1417e91 to 2114fff Compare March 25, 2019 16:56
@bmarty bmarty merged commit 33f2717 into develop Mar 25, 2019
@bmarty bmarty deleted the feature/fix_partial_keyshare branch March 25, 2019 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manuroe manuroe manuroe approved these changes

@bmarty bmarty Awaiting requested review from bmarty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillCarsonFr @manuroe @bmarty