This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Remove Room.getLiveState() and keep only Room.getState() #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d because they are similar.
bmarty
suggested changes
Jul 16, 2018
CHANGES.rst
Outdated
| @@ -17,6 +17,7 @@ Bugfix: | |||
| API Change: | |||
| - Parameter historyVisibility removed from MxSession.createRoom(). It had no effect. | |||
| - New API: CreateRoomParams.setHistoryVisibility(String historyVisibility) to force the history visibility during Room creation. | |||
| - New API: use only the method Room.getState() and remove Room.getLiveState() because they are similar. | |||
There was a problem hiding this comment.
Replace this line with:
- Room.getLiveState() has been removed, please use Room.getState()
| @@ -3023,7 +3021,7 @@ public void onSuccess(Void info) { | |||
| // - Alice and Bob start sharing a room again | |||
| CountDownLatch lock3 = new CountDownLatch(1); | |||
| aliceSession2.createRoom(null, null, RoomState.DIRECTORY_VISIBILITY_PUBLIC, null, RoomState.GUEST_ACCESS_CAN_JOIN, | |||
| RoomState.HISTORY_VISIBILITY_SHARED, null, new TestApiCallback<String>(lock3) { | |||
| null, new TestApiCallback<String>(lock3) { | |||
| @@ -2430,8 +2430,7 @@ public void test25_testLeftAndJoinedBob() throws Exception { | |||
| mBobSession.getCrypto().setWarnOnUnknownDevices(false); | |||
|
|
|||
| CountDownLatch lock0 = new CountDownLatch(1); | |||
| mAliceSession.createRoom(null, null, RoomState.DIRECTORY_VISIBILITY_PUBLIC, null, RoomState.GUEST_ACCESS_CAN_JOIN, | |||
| RoomState.HISTORY_VISIBILITY_SHARED, null, new TestApiCallback<String>(lock0) { | |||
| mAliceSession.createRoom(null, null, RoomState.DIRECTORY_VISIBILITY_PUBLIC, null, RoomState.GUEST_ACCESS_CAN_JOIN, null, new TestApiCallback<String>(lock0) { | |||
bmarty
suggested changes
Jul 16, 2018
| @@ -2902,8 +2901,7 @@ public void onSuccess(Void info) { | |||
| mBobSession.getCrypto().setWarnOnUnknownDevices(false); | |||
|
|
|||
| CountDownLatch lock0 = new CountDownLatch(1); | |||
| mAliceSession.createRoom(null, null, RoomState.DIRECTORY_VISIBILITY_PUBLIC, null, RoomState.GUEST_ACCESS_CAN_JOIN, | |||
| RoomState.HISTORY_VISIBILITY_SHARED, null, new TestApiCallback<String>(lock0) { | |||
| mAliceSession.createRoom(null, null, RoomState.DIRECTORY_VISIBILITY_PUBLIC, null, RoomState.GUEST_ACCESS_CAN_JOIN,null, new TestApiCallback<String>(lock0) { | |||
bmarty
approved these changes
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because they are similar.
Related to #310